Fix playback of compressed bagfiles#417
Merged
emersonknapp merged 1 commit intomasterfrom May 26, 2020
Merged
Conversation
zmichaels11
approved these changes
May 20, 2020
prajakta-gokhale
approved these changes
May 20, 2020
prajakta-gokhale
left a comment
prajakta-gokhale
left a comment
There was a problem hiding this comment.
Wondering if this method needs to be part of the class or an interface in future, if it's needed in other implementations.
emersonknapp
force-pushed
the
emersonknapp/compression-segfault
branch
from
6c60c0d to
61bae17
Compare
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
emersonknapp
force-pushed
the
emersonknapp/compression-segfault
branch
from
61bae17 to
231c4a9
Compare
Collaborator
Author
|
piraka9011
approved these changes
May 21, 2020
Contributor
piraka9011
left a comment
piraka9011
left a comment
There was a problem hiding this comment.
Looks like rosbag2_transport tests failing on Mac OS and Windows.
Otherwise LGTM.
Collaborator
Author
Just trying them, it seems like my change is unrelated - and the |
Collaborator
Author
|
The failing tests are the noted unstable tests, merging this change to unblock further stability work |
pjreed
pushed a commit
to pjreed/rosbag2
that referenced
this pull request
May 28, 2020
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com> Signed-off-by: P. J. Reed <preed@swri.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SequentialCompressionReader was not filling in the data for
get_all_topics_and_typessince #372Fixes #412
The newly added test fails before the change in SequentialCompressionReader, passes after
Signed-off-by: Emerson Knapp emerson.b.knapp@gmail.com